Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix cocreature's temp machine #5341

Merged
merged 1 commit into from
Apr 1, 2020
Merged

fix cocreature's temp machine #5341

merged 1 commit into from
Apr 1, 2020

Conversation

garyverhaegen-da
Copy link
Contributor

@garyverhaegen-da garyverhaegen-da commented Apr 1, 2020

Our Linux startup script never finishes, as it ends with exec'ing to the Azure agent. Since I've removed that part, the EXIT handler, supposed to only kick in when an issue prevents the script from finishing, triggers on normal exit, and the machine shuts down. Making it hard to use.

CHANGELOG_BEGIN
CHANGELOG_END

Our Linux startup script never finishes, as it ends with `exec`'ing to
the Azure agent. Since I've removed that part, the EXIT handler,
supposed to only kick in when an issue prevents the script from
finishing, triggers on normal exit, and the machine shuts down. Making
it hard to use.

CHANGELOG_BEGIN
CHANGELOG_END
Copy link
Contributor

@hurryabit hurryabit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

@cocreature cocreature left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@garyverhaegen-da
Copy link
Contributor Author

In the interest of time, applying before CI finishes and thus before merging to master. Successfully applied commit 7cf3834, as expected creating a new Linux template, deleting the old one, and updating the group manager to use the new template.

@garyverhaegen-da garyverhaegen-da merged commit ce5ad64 into master Apr 1, 2020
@garyverhaegen-da garyverhaegen-da deleted the fix-moritz-linux branch April 1, 2020 13:28
@garyverhaegen-da
Copy link
Contributor Author

Can confirm Terraform still applies cleanly on ce5ad64 (as a sanity check).

stefanobaghino-da added a commit that referenced this pull request Apr 1, 2020
stefanobaghino-da added a commit that referenced this pull request Apr 1, 2020
stefanobaghino-da added a commit that referenced this pull request Apr 1, 2020
stefanobaghino-da added a commit that referenced this pull request Apr 1, 2020
stefanobaghino-da added a commit that referenced this pull request Apr 1, 2020
stefanobaghino-da added a commit that referenced this pull request Apr 1, 2020
stefanobaghino-da added a commit that referenced this pull request Apr 1, 2020
stefanobaghino-da added a commit that referenced this pull request Apr 1, 2020
stefanobaghino-da added a commit that referenced this pull request Apr 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants