Bump ghcide #5128
Merged
Bump ghcide #5128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sadly there seem to be a couple of issues, investigating. |
cocreature
force-pushed
the
bump-ghcide
branch
2 times, most recently
from
d48a310 to
3392097
Compare
This PR bumps ghcide, haskell-lsp and haskell-lsp-types. There aren’t really any important changes in ghcide itself but the haskell-lsp update includes my fix for crashing completions. One change in ghcide itself is that NormalizedFilePath got moved to haskell-lsp. ghcide needs special treatment for empty file paths so we use `toNormalizedFilePath'` from ghcide instead of `toNormalizedFilePath` from `haskell-lsp`. I’ve added an hlint rule to enforce this. changelog_begin changelog_end
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR bumps ghcide, haskell-lsp and haskell-lsp-types. There aren’t
really any important changes in ghcide itself but the haskell-lsp
update includes my fix for crashing completions.
One change in ghcide itself is that NormalizedFilePath got moved to
haskell-lsp. ghcide needs special treatment for empty file paths so we
use
toNormalizedFilePath'from ghcide instead oftoNormalizedFilePathfromhaskell-lsp. I’ve added an hlint rule toenforce this.
changelog_begin
changelog_end
Pull Request Checklist
CHANGELOG_BEGINandCHANGELOG_ENDtagsNOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with
/AzurePipelines runtotrigger the build.