Update hlint #5123
Merged
Update hlint #5123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shayne-fletcher
force-pushed
the
update-hlint
branch
4 times, most recently
from
d8ca9c7 to
a629019
Compare
cocreature
reviewed
Mar 22, 2020
shayne-fletcher
force-pushed
the
update-hlint
branch
from
a629019 to
08f0491
Compare
|
@cocreature PR adjusted as per your comments. |
shayne-fletcher
force-pushed
the
update-hlint
branch
from
08f0491 to
4618e08
Compare
changelog_begin changelog_end
shayne-fletcher
force-pushed
the
update-hlint
branch
from
4618e08 to
ef219f1
Compare
hurryabit
reviewed
Mar 23, 2020
| @@ -1,6 +1,8 @@ | |||
| -- Copyright (c) 2020, Digital Asset (Switzerland) GmbH and/or its affiliates. | |||
| -- All rights reserved. | |||
|
|
|||
| -- @INFO Use catOptionals | |||
|
|
|||
There was a problem hiding this comment.
What are we testing here? And why is this test called ActionFail?
There was a problem hiding this comment.
That's lost in the mists of time but if I had to guess, it's that fail works correctly in the presence of RebindableSyntax (ghc-proposals/ghc-proposals#168).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update hlint. Depends on digital-asset/hlint#52