Make extractor and navigator work without client auth #4966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cocreature
requested review from
bame-da,
gerolf-da,
hurryabit,
leo-da,
nemanja-da,
rautenrieth-da and
S11001001
as code owners
stefanobaghino-da
approved these changes
Mar 12, 2020
cocreature
force-pushed
the
java-no-client-auth
branch
from
8627107 to
f243267
Compare
This PR fixes the tls configuration to work if client auth is not enabled and adds a `--tls` flag to extractor and navigator which allows you to enable tls without overriding any certificates. There is a test for extractor but none for navigator since there are no tls tests at all afaict atm. I did however test it manually. changelog_begin - [Navigator] Navigator can now run a TLS enabled ledger without client authentication. You can enable TLS without any special certificates by passing ``--tls``. - [Extractor] Extractor can now run a TLS enabled ledger without client authentication. You can enable TLS without any special certificates by passing ``--tls``. changelog_end
cocreature
force-pushed
the
java-no-client-auth
branch
from
f243267 to
4f5ceb3
Compare
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This depends on #4965, I’ll rebase as soon as that is merged.
This PR fixes the tls configuration to work if client auth is not
enabled and adds a
--tlsflag to extractor and navigator whichallows you to enable tls without overriding any certificates.
There is a test for extractor but none for navigator since there are
no tls tests at all afaict atm. I did however test it manually.
changelog_begin
[Navigator] Navigator can now run a TLS enabled ledger without
client authentication. You can enable TLS without any special
certificates by passing
--tls.[Extractor] Extractor can now run a TLS enabled ledger without
client authentication. You can enable TLS without any special
certificates by passing
--tls.changelog_end
Pull Request Checklist
CHANGELOG_BEGINandCHANGELOG_ENDtagsNOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with
/AzurePipelines runtotrigger the build.