Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include generated ts documentation #4924

Merged
1 commit merged into from
Mar 10, 2020
Merged

Include generated ts documentation #4924

1 commit merged into from
Mar 10, 2020

Conversation

ghost
Copy link

@ghost ghost commented Mar 10, 2020

This adds the generated documentation for our ts libraries @daml/react,
@daml/types and @daml/ledger to our documentation on docs.daml.com.

Next step is to update the README's of those libraries.

Pull Request Checklist

  • Read and understand the contribution guidelines
  • Include appropriate tests
  • Set a descriptive title and thorough description
  • Add a reference to the issue this PR will solve, if appropriate
  • Include changelog additions in one or more commit message bodies between the CHANGELOG_BEGIN and CHANGELOG_END tags
  • Normal production system change, include purpose of change in description

NOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with /AzurePipelines run to
trigger the build.

shayne-fletcher
shayne-fletcher approved these changes Mar 10, 2020
View reviewed changes
Copy link
Contributor

@shayne-fletcher shayne-fletcher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Slick!

@ghost ghost force-pushed the include_ts_gen_docs branch 3 times, most recently from 9fbf007 to cb0e17f Compare March 10, 2020 17:12
lanugage:docs: include generated docs on docs.daml.com
8a2be5e 
This includes the generated docs for the typescipt libraries daml-react,
daml-ledger and daml-types in the documentation presented on
docs.daml.com. Next step is to create better readmes in this libraries.

CHANGELOG_BEGIN
CHANGELOG_END
@ghost ghost force-pushed the include_ts_gen_docs branch from cb0e17f to 8a2be5e Compare March 10, 2020 17:21
@ghost ghost merged commit 8fe497e into master Mar 10, 2020
@ghost ghost deleted the include_ts_gen_docs branch March 10, 2020 17:46
hurryabit
hurryabit reviewed Mar 11, 2020
View reviewed changes
Copy link
Contributor

@hurryabit hurryabit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome. Thanks.

Was the file docs/source/app-dev/bindings-ts/daml-react/test added by accident?

@cocreature cocreature mentioned this pull request Mar 12, 2020
Merged
6 tasks
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bame-da bame-da Awaiting requested review from bame-da

@nemanja-da nemanja-da Awaiting requested review from nemanja-da

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shayne-fletcher @hurryabit