Include Bazel patch to mark tests as exclusive #4918
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefanobaghino-da
approved these changes
Mar 10, 2020
garyverhaegen-da
approved these changes
Mar 10, 2020
aherrmann-da
approved these changes
Mar 10, 2020
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
cocreature
force-pushed
the
bazel-cache-exclusive
branch
2 times, most recently
from
5c2e64d to
cf0f4f5
Compare
This should hopefully avoid rerunning the conformance tests as often as we do now. While this patch is not applied on Windows (since we get it from nix), this is not really an issue since most of the exclusive tests (in particular, all conformance tests) are disabled on Windows anyway. I’ve tested this locally accross a couple of runs and I get the caching I want and looking at the code in the patch, the change looks very reasonable. I somewhat wonder if it just broke internally at google because they marked tests as exclusive that should have gotten no-cache. changelog_begin changelog_end
cocreature
force-pushed
the
bazel-cache-exclusive
branch
from
cf0f4f5 to
98152ce
Compare
garyverhaegen-da
approved these changes
Mar 10, 2020
| @@ -65,6 +65,9 @@ conformance_test( | |||
| ], | |||
| runner = "@//bazel_tools/client_server/runner:runner", | |||
| server = ":canton-test-runner-with-dependencies", | |||
| # NOTE (MK): Canton tries to access ~/.ammonite/cache for the coursier cache which fails with sandboxing | |||
| # and caching. This might be fixable by overriding COURSIER_CACHE. | |||
| tags = ["local"], | |||
There was a problem hiding this comment.
Makes sense to me. Thanks for the workaround.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should hopefully avoid rerunning the conformance tests as often
as we do now. While this patch is not applied on Windows (since we get
it from nix), this is not really an issue since most of the exclusive
tests (in particular, all conformance tests) are disabled on Windows
anyway.
I’ve tested this locally accross a couple of runs and I get the
caching I want and looking at the code in the patch, the change looks
very reasonable. I somewhat wonder if it just broke internally at
google because they marked tests as exclusive that should have gotten
no-cache.
changelog_begin
changelog_end
Pull Request Checklist
CHANGELOG_BEGINandCHANGELOG_ENDtagsNOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with
/AzurePipelines runtotrigger the build.