Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unexperimentalize DAML script #4856

Merged
merged 1 commit into from
Mar 5, 2020
Merged

Unexperimentalize DAML script #4856

merged 1 commit into from
Mar 5, 2020

Conversation

cocreature
Copy link
Contributor

The only remaining thing that I wanted to get in before doing that was
overloading submit which has now happened. I’m sure we can come up
with tons of improvements but I don’t expect breaking changes to the
current state.

changelog_begin

  • [DAML Script] DAML Script is no longer experimental.

changelog_end

fixes #4615

Pull Request Checklist

  • Read and understand the contribution guidelines
  • Include appropriate tests
  • Set a descriptive title and thorough description
  • Add a reference to the issue this PR will solve, if appropriate
  • Include changelog additions in one or more commit message bodies between the CHANGELOG_BEGIN and CHANGELOG_END tags
  • Normal production system change, include purpose of change in description

NOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with /AzurePipelines run to
trigger the build.

@cocreature
Unexperimentalize DAML script
5de1055 
The only remaining thing that I wanted to get in before doing that was
overloading ``submit`` which has now happened. I’m sure we can come up
with tons of improvements but I don’t expect breaking changes to the
current state.

changelog_begin

- [DAML Script] DAML Script is no longer experimental.

changelog_end

fixes #4615
@cocreature cocreature requested a review from nemanja-da as a code owner March 5, 2020 16:25
ghost
ghost approved these changes Mar 5, 2020
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, great job!

shayne-fletcher
shayne-fletcher reviewed Mar 5, 2020
View reviewed changes
Copy link
Contributor

@shayne-fletcher shayne-fletcher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@cocreature cocreature merged commit fa96869 into master Mar 5, 2020
@cocreature cocreature deleted the unexperimentalize-daml-script branch March 5, 2020 19:40
hurryabit
hurryabit reviewed Mar 6, 2020
View reviewed changes
Copy link
Contributor

@hurryabit hurryabit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super nice! 🎉

aherrmann-da
aherrmann-da reviewed Mar 6, 2020
View reviewed changes
Copy link
Contributor

@aherrmann-da aherrmann-da left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aherrmann-da aherrmann-da aherrmann-da left review comments

@hurryabit hurryabit hurryabit left review comments

@shayne-fletcher shayne-fletcher shayne-fletcher left review comments

@bame-da bame-da Awaiting requested review from bame-da

@nemanja-da nemanja-da Awaiting requested review from nemanja-da

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unexperimentalizing and stabilifying DAML script
4 participants
@cocreature @shayne-fletcher @hurryabit @aherrmann-da