Sandbox-Next: Add the ResetService. #4802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`reset()` releases the resource, performs an optional reset operation, and then re-acquires it, binding it to the same variable.
CHANGELOG_BEGIN CHANGELOG_END
It was being too clever and negating its own asynchronous behavior.
This double negative is really hard to phrase well.
It's no longer meaningful.
ghost
requested review from
gerolf-da,
rautenrieth-da and
stefanobaghino-da
as code owners
It looks like it's definitely slower than on Sandbox Classic™. Gonna look into this as part of future work.
|
Currently, resetting is about twice as slow as with Sandbox Classic™. I'm going to dig into this, but I don't want to blow this PR up much more. |
gerolf-da
reviewed
Mar 4, 2020
.../sandbox/src/main/scala/com/digitalasset/platform/sandbox/services/SandboxResetService.scala
Outdated
Show resolved
Hide resolved
...src/test/lib/scala/com/digitalasset/platform/sandbox/services/reset/ResetServiceITBase.scala
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried to split out the resetting behavior itself into the general resources package to make testing easier.
Resolves #4600.
Pull Request Checklist
CHANGELOG_BEGINandCHANGELOG_ENDtagsNOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with
/AzurePipelines runtotrigger the build.