recommended architecture and deploy docs #4795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
force-pushed
the
recommended_path_docs
branch
2 times, most recently
from
5074265 to
f7fddf7
Compare
nemanja-da
reviewed
Mar 4, 2020
nemanja-da
reviewed
Mar 4, 2020
nemanja-da
reviewed
Mar 4, 2020
nemanja-da
reviewed
Mar 4, 2020
nemanja-da
reviewed
Mar 4, 2020
nemanja-da
reviewed
Mar 4, 2020
nemanja-da
reviewed
Mar 4, 2020
nemanja-da
reviewed
Mar 4, 2020
nemanja-da
reviewed
Mar 4, 2020
nemanja-da
reviewed
Mar 4, 2020
nemanja-da
reviewed
Mar 4, 2020
nemanja-da
reviewed
Mar 4, 2020
nemanja-da
reviewed
Mar 4, 2020
cocreature
reviewed
Mar 4, 2020
There was a problem hiding this comment.
Nice work, I’ll leave the approval to the expert on documentation @nemanja-da 🙂
nemanja-da
reviewed
Mar 5, 2020
nemanja-da
reviewed
Mar 5, 2020
nemanja-da
reviewed
Mar 5, 2020
nemanja-da
reviewed
Mar 5, 2020
nemanja-da
reviewed
Mar 5, 2020
ghost
requested review from
garyverhaegen-da,
gerolf-da,
leo-da,
nickchapman-da,
rautenrieth-da and
S11001001
as code owners
ghost
self-requested a review
|
Is there some rebase to do here? 🤔 |
|
not sure what's going on with the code owners here. |
|
Given that we're squash-merging on master, you should not try to update your local branches by merging (otherwise this happens). I've found the best way to work with a squashed main branch is to always rebase and keep PRs to a single commit. |
ghost
force-pushed
the
recommended_path_docs
branch
2 times, most recently
from
49134b3 to
603f8c1
Compare
|
squashed to one commit and force pushed. |
ghost
force-pushed
the
recommended_path_docs
branch
3 times, most recently
from
2e46631 to
3f6b76d
Compare
nemanja-da
reviewed
Mar 9, 2020
ghost
force-pushed
the
recommended_path_docs
branch
2 times, most recently
from
2ac1d47 to
1d52e4b
Compare
CHANGELOG_BEGIN CHANGELOG_END
ghost
force-pushed
the
recommended_path_docs
branch
from
1d52e4b to
02d5275
Compare
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates and simplifies the documentation on the recommended architecture
and deployment.
Probably best reviewed with the loca preview function on the branch.
Pull Request Checklist
CHANGELOG_BEGINandCHANGELOG_ENDtagsNOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with
/AzurePipelines runtotrigger the build.