Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump zip library #4768

Merged
merged 1 commit into from
Mar 2, 2020
Merged

Bump zip library #4768

merged 1 commit into from
Mar 2, 2020

Conversation

cocreature
Copy link
Contributor

This should hopefully fix the failure to delete the temporary zip file
on Windows. See mrkkrp/zip#61

changelog_begin
changelog_end

Pull Request Checklist

  • Read and understand the contribution guidelines
  • Include appropriate tests
  • Set a descriptive title and thorough description
  • Add a reference to the issue this PR will solve, if appropriate
  • Include changelog additions in one or more commit message bodies between the CHANGELOG_BEGIN and CHANGELOG_END tags
  • Normal production system change, include purpose of change in description

NOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with /AzurePipelines run to
trigger the build.

@cocreature
Bump zip library
0eab248 
This should hopefully fix the failure to delete the temporary zip file
on Windows. See mrkkrp/zip#61

changelog_begin
changelog_end
@cocreature cocreature requested review from a user and aherrmann-da March 2, 2020 10:40
aherrmann-da
aherrmann-da approved these changes Mar 2, 2020
View reviewed changes
Copy link
Contributor

@aherrmann-da aherrmann-da left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix!

@cocreature
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 1 pipeline(s).

@cocreature cocreature closed this Mar 2, 2020
@cocreature cocreature reopened this Mar 2, 2020
@cocreature cocreature merged commit d36bb65 into master Mar 2, 2020
@cocreature cocreature deleted the bump-zip branch March 2, 2020 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aherrmann-da aherrmann-da aherrmann-da approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cocreature @aherrmann-da