Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: publish the bazel test logs #476

Merged
1 commit merged into from
Apr 16, 2019
Merged

ci: publish the bazel test logs #476

1 commit merged into from
Apr 16, 2019

Conversation

ghost
Copy link

@ghost ghost commented Apr 15, 2019

As a developer I want to be able to inspect the detailed test logs when those are
failing.

Pull Request Checklist

NOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with /AzurePipelines run to
trigger the build.

@ghost ghost requested a review from moritzkiefer-da April 15, 2019 09:43
@ghost
Copy link
Author

ghost commented Apr 15, 2019

do we always want the test logs or only on failure?

Copy link
Contributor

@moritzkiefer-da moritzkiefer-da left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@neil-da
Copy link
Contributor

neil-da commented Apr 15, 2019

I don't think anyone cares if they succeeded. What's the cost of doing it always though? In terms of cash/time or whatever.

@ghost
Copy link
Author

ghost commented Apr 15, 2019

@neil-da it adds another 57s to the build

@ghost ghost force-pushed the ci-bazel-testlogs branch from 1d40a66 to 521fa12 Compare April 15, 2019 18:28
@ghost
Copy link
Author

ghost commented Apr 15, 2019

changed it to only publish on failure

As a developer I want to be able to inspect the detailed test logs when those are
failing.
@ghost ghost force-pushed the ci-bazel-testlogs branch from 521fa12 to 0dee48a Compare April 16, 2019 09:07
Copy link
Contributor

@cocreature cocreature left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reapproving

@ghost ghost merged commit a061db3 into master Apr 16, 2019
@ghost ghost deleted the ci-bazel-testlogs branch April 16, 2019 09:34
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants