Upgrade to ghc-lib-8.8.1.20200225 #4692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cocreature
reviewed
Feb 25, 2020
|
@cocreature The next PR I raise will remove |
|
I prefer tests in the same PR that adds a new feature or introduces a change. |
shayne-fletcher
force-pushed
the
update-ghc-lib
branch
from
3d61641 to
b0876f0
Compare
|
Two new files added:
|
cocreature
approved these changes
Feb 25, 2020
shayne-fletcher
force-pushed
the
update-ghc-lib
branch
2 times, most recently
from
63333e3 to
22a6caa
Compare
- Prelude `daml 1.2` is now optional; - `HsDumpAst` now comes from `ghc-lib-parser`. changelog_begin changelog_end
shayne-fletcher
force-pushed
the
update-ghc-lib
branch
from
22a6caa to
d678f3e
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
hurryabit
reviewed
Feb 25, 2020
| @@ -227,7 +227,7 @@ basicTests mbScenarioService = Tasty.testGroup "Basic tests" | |||
| setFilesOfInterest [a] | |||
| expectWarning (a,0,25) "The import of ‘B’ is redundant" | |||
| setBufferModified a "???" | |||
| expectOneError (a,0,0) "Missing daml version" | |||
There was a problem hiding this comment.
I must be missing something: How was there a "Missing daml version" error in the past?
There was a problem hiding this comment.
well there is no DAML version if you replace the content by ??? 🙂
There was a problem hiding this comment.
That is exactly the thing I missed. Thanks for pointing me at it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
daml 1.2is now optional;HsDumpAstnow comes fromghc-lib-parser.