Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@daml/react: Add rerendering test for useQuery #4662

Merged
merged 1 commit into from
Feb 24, 2020

Conversation

hurryabit
Copy link
Contributor

@hurryabit hurryabit commented Feb 24, 2020

Add a test for useQuery that ensure that we don't call the JSON API
if the component calling the hook changes without changing the query.

CHANGELOG_BEGIN
CHANGELOG_END

Pull Request Checklist

  • Read and understand the contribution guidelines
  • Include appropriate tests
  • Set a descriptive title and thorough description
  • Add a reference to the issue this PR will solve, if appropriate
  • Include changelog additions in one or more commit message bodies between the CHANGELOG_BEGIN and CHANGELOG_END tags
  • Normal production system change, include purpose of change in description

NOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with /AzurePipelines run to
trigger the build.


This change is Reviewable

Add a test for `useQuery` that ensure that we don't call the JSON API
if the component calling the hook changes without changing the query.

CHANGELOG_BEGIN
CHANGELOG_END
@hurryabit hurryabit requested a review from a user February 24, 2020 10:04
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mergify mergify bot merged commit c73d902 into master Feb 24, 2020
@mergify mergify bot deleted the daml-react-test-rerendering branch February 24, 2020 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant