Reuse the same Engine object between ledger resets #466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gerolf-da
force-pushed
the
reuse-engine-between-resets
branch
from
d40f87a to
57cdb0b
Compare
Compared to older versions of the Engine, we do A LOT more validation now. So when starting with a fresh engine after each reset (via the ResetService), we also repeat the validation of the loaded packages again and again. This is VERY expensive, especially for large DAML packages. Luckily, the specification of the ResetService states the following: // Resets the ledger state. Note that loaded DARs won't be removed -- // this only rolls back the ledger to genesis. This means that we can re-use the same Engine object and benefit from not having "re-compile" packages via ConcurrentCompiledPackages#addPackage, more specifically we can omit this line: https://github.com/digital-asset/daml/blob/1f2246c822acd1d44a6b0ed223f0b063f4a4e2cf/daml-lf/engine/src/main/scala/com/digitalasset/daml/lf/engine/ConcurrentCompiledPackages.scala#L56 Fixes #178
gerolf-da
force-pushed
the
reuse-engine-between-resets
branch
from
57cdb0b to
999d0fd
Compare
|
Looking great! |
gabor-aranyossy
approved these changes
Apr 15, 2019
jberthold-da
approved these changes
Apr 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compared to older versions of the Engine, we do A LOT more validation
now. So when starting with a fresh engine after each reset (via
the ResetService), we also repeat the validation of the loaded packages
again and again. This is VERY expensive, especially for large DAML
packages.
Luckily, the specification of the ResetService states the following:
// Resets the ledger state. Note that loaded DARs won't be removed --
// this only rolls back the ledger to genesis.
This means that we can re-use the same Engine object and benefit from
not having "re-compile" packages via
ConcurrentCompiledPackages#addPackage, more specifically we can avoid
executing this line by having retained all compiled packages in the engine:
daml/daml-lf/engine/src/main/scala/com/digitalasset/daml/lf/engine/ConcurrentCompiledPackages.scala
Line 56 in 1f2246c
Fixes #178
Pull Request Checklist
NOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with
/AzurePipelines runtotrigger the build.