Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Relieve Ledger API DB thread pool of unnecessary work #4657

Merged
merged 1 commit into from
Feb 24, 2020
Merged

Relieve Ledger API DB thread pool of unnecessary work #4657

merged 1 commit into from
Feb 24, 2020

Conversation

stefanobaghino-da
Copy link
Contributor

Smaller sibling of #4655

CHANGELOG_BEGIN
[Ledger API Server] Better usage of computing resources, should sustain heavier loads
CHANGELOG_END

Pull Request Checklist

  • Read and understand the contribution guidelines
  • Include appropriate tests
  • Set a descriptive title and thorough description
  • Add a reference to the issue this PR will solve, if appropriate
  • Include changelog additions in one or more commit message bodies between the CHANGELOG_BEGIN and CHANGELOG_END tags
  • Normal production system change, include purpose of change in description

NOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with /AzurePipelines run to
trigger the build.

@stefanobaghino-da stefanobaghino-da requested a review from a user February 21, 2020 16:41
@stefanobaghino-da stefanobaghino-da force-pushed the relieve-lapi-db-threadpool branch from 6c51b15 to 4e15d99 Compare February 21, 2020 17:24
@stefanobaghino-da
Relieve Ledger API DB thread pool of unnecessary work
c1109b0 
Smaller sibling of #4655

CHANGELOG_BEGIN
[Ledger API Server] Better usage of computing resources, should sustain heavier loads
CHANGELOG_END
@stefanobaghino-da stefanobaghino-da force-pushed the relieve-lapi-db-threadpool branch from 4e15d99 to c1109b0 Compare February 21, 2020 17:25
ghost
ghost approved these changes Feb 22, 2020
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't realize this doesn't affect Sandbox, but other ledgers running indexers. That said, still looks great to me.

ledger/sandbox/src/main/scala/com/digitalasset/platform/store/dao/JdbcLedgerDao.scala Show resolved Hide resolved
@stefanobaghino-da stefanobaghino-da merged commit 347990c into master Feb 24, 2020
@stefanobaghino-da stefanobaghino-da deleted the relieve-lapi-db-threadpool branch February 24, 2020 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gerolf-da gerolf-da Awaiting requested review from gerolf-da

@rautenrieth-da rautenrieth-da Awaiting requested review from rautenrieth-da

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@stefanobaghino-da