recovering-indexer-integration-tests: Extract from reference-v2. #4636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This moves IndexerIT into its own package, and swaps the dependency from reference-v2 to ledger-on-memory. This test should ideally live in the sandbox code, but because it depends on ledger-on-memory, it's easier to keep it separate. Also rewrites a lot of the code because the API is different. The tests should now be clearer too. I've also marked the test as flaky, because, well, it is. CHANGELOG_BEGIN CHANGELOG_END
ghost
requested review from
gerolf-da,
rautenrieth-da and
stefanobaghino-da
as code owners
ghost
added
the
mergify
bot
deleted the
ledger/recovering-indexer-integration-tests/extract-from-reference-v2
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves IndexerIT into its own package, and swaps the dependency from reference-v2 to ledger-on-memory.
This test should ideally live in the sandbox code, but because it depends on ledger-on-memory, and needs its own logback-test.xml, it's easier to keep it separate.
Also rewrites a lot of the code because the API is different. The tests should now be clearer too.
I've also marked the test as flaky, because, well, it is.
This is part of #4225.
Pull Request Checklist
CHANGELOG_BEGINandCHANGELOG_ENDtagsNOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with
/AzurePipelines runtotrigger the build.