DAML-LF: cleanup transaction version #4557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remyhaemmerle-da
requested review from
gerolf-da,
leo-da,
rautenrieth-da and
S11001001
as code owners
gerolf-da
reviewed
Feb 18, 2020
| @@ -193,9 +193,8 @@ object Cli { | |||
| .action( (url, config) => config.copy(authService = Some(AuthServiceJWT(JwksVerifier(url))))) | |||
|
|
|||
| opt[Unit]("sortable-contract-ids") | |||
| .hidden() | |||
There was a problem hiding this comment.
Please keep it hidden, as it is more a flag for us to be able to toggle it, but not intended to be used by end users.
remyhaemmerle-da
force-pushed
the
contract-id
branch
from
363066e to
31bf27b
Compare
gerolf-da
approved these changes
Feb 18, 2020
remyhaemmerle-da
changed the title
--sortable-contract-ids flag available
remyhaemmerle-da
force-pushed
the
contract-id
branch
from
31bf27b to
b9a7079
Compare
drop unused and non-necessary transaction version 10. CHANGELOG_BEGIN CHANGELOG_END
remyhaemmerle-da
force-pushed
the
contract-id
branch
from
b9a7079 to
7b9b745
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We clean transaction versions. Concretely, we drop the transaction version 10 which is currently not necessary (and not use in production).
This advances the state of #3830.
Pull Request Checklist
CHANGELOG_BEGINandCHANGELOG_ENDtagsNOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with
/AzurePipelines runtotrigger the build.