Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplified API fixes #4505

Merged
merged 4 commits into from
Feb 13, 2020
Merged

Simplified API fixes #4505

merged 4 commits into from
Feb 13, 2020

Conversation

miklos-da
Copy link
Contributor

@miklos-da miklos-da commented Feb 13, 2020

Summary of changes:

  • Removed LedgerStateAccess.participantId so that we can reuse submission validators.
  • Renamed LedgerReader.retrieveLedgerId to ledgerId to be in line with naming conventions..

Pull Request Checklist

  • Read and understand the contribution guidelines
  • Include appropriate tests
  • Set a descriptive title and thorough description
  • Add a reference to the issue this PR will solve, if appropriate
  • Include changelog additions in one or more commit message bodies between the CHANGELOG_BEGIN and CHANGELOG_END tags
  • Normal production system change, include purpose of change in description

NOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with /AzurePipelines run to
trigger the build.

@miklos-da miklos-da marked this pull request as ready for review February 13, 2020 17:11
@miklos-da miklos-da requested a review from a user February 13, 2020 17:11
@miklos-da
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 1 pipeline(s).

@miklos-da miklos-da merged commit a440a3f into master Feb 13, 2020
@miklos-da miklos-da deleted the simplified-api-fixes branch February 13, 2020 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant