Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release: Sort artifacts.yaml. #4502

Merged
merged 1 commit into from
Feb 13, 2020
Merged

release: Sort artifacts.yaml. #4502

merged 1 commit into from
Feb 13, 2020

Conversation

ghost
Copy link

@ghost ghost commented Feb 13, 2020

I verified that there are no semantic changes, only cosmetic ones, by
running the following before and after, and checking the diff.

< release/artifacts.yaml ruby -rjson -ryaml -e 'puts JSON::generate YAML::load $stdin' | jq '. | sort_by(.target)' > ~/Desktop/artifacts.{old,new}.json

Pull Request Checklist

  • Read and understand the contribution guidelines
  • Include appropriate tests
  • Set a descriptive title and thorough description
  • Add a reference to the issue this PR will solve, if appropriate
  • Include changelog additions in one or more commit message bodies between the CHANGELOG_BEGIN and CHANGELOG_END tags
  • Normal production system change, include purpose of change in description

NOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with /AzurePipelines run to
trigger the build.

@SamirTalwar
release: Sort artifacts.yaml.
b4f17e2 
I verified that there are no semantic changes, only cosmetic ones, by
running the following before and after, and checking the diff.

```
< release/artifacts.yaml ruby -rjson -ryaml -e 'puts JSON::generate YAML::load $stdin' | jq '. | sort_by(.target)' > ~/Desktop/artifacts.{old,new}.json
```

CHANGELOG_BEGIN
CHANGELOG_END
@ghost ghost requested review from cocreature and gerolf-da February 13, 2020 13:29
cocreature
cocreature approved these changes Feb 13, 2020
View reviewed changes
Copy link
Contributor

@cocreature cocreature left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sounds reasonable, I don’t care about the order.

@ghost
Copy link
Author

ghost commented Feb 13, 2020

Just makes it easier to know where to put the next thing. 🙂

@cocreature
Copy link
Contributor

Just makes it easier to know where to put the next thing. slightly_smiling_face

At the bottom :trollface:

@ghost ghost added the automerge label Feb 13, 2020
@mergify mergify bot merged commit 2c4807f into master Feb 13, 2020
@mergify mergify bot deleted the release/sort-artifacts branch February 13, 2020 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gerolf-da gerolf-da Awaiting requested review from gerolf-da

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cocreature @SamirTalwar