Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add allocatePartyWithHint(On) to DAML Script #4489

Merged
merged 4 commits into from
Feb 12, 2020
Merged

Add allocatePartyWithHint(On) to DAML Script #4489

merged 4 commits into from
Feb 12, 2020

Conversation

aherrmann-da
Copy link
Contributor

Closes #4472

  • Adds allocatePartyWithHint and allocatePartyWithHintOn to specify the party_id_hint from DAML script.
  • Wraps the PartyIdHint and ParticipantName arguments in newtype wrappers to avoid confusing and error-prone types such as allocatePartyWithHintOn : Text -> Text -> Text -> Script Party.
  • Adds test cases for the single and multi participant cases.

Pull Request Checklist

  • Read and understand the contribution guidelines
  • Include appropriate tests
  • Set a descriptive title and thorough description
  • Add a reference to the issue this PR will solve, if appropriate
  • Include changelog additions in one or more commit message bodies between the CHANGELOG_BEGIN and CHANGELOG_END tags
  • Normal production system change, include purpose of change in description

NOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with /AzurePipelines run to
trigger the build.

@aherrmann
allocatePartyWithHint(On)
e1b3071 
CHANGELOG_BEGIN
- [DAML Script - Experimental] The participant argument in ``allocatePartyOn`` is wrapped in ``ParticipantName`` to avoid confusion with the ``displayName`` argument.
- [DAML Script - Experimental] Add ``allocatePartyWithHint`` and ``allocatePartyWithHintOn`` that allow to specify the ``partyIdHint`` to the backing participant. See #4472.
CHANGELOG_END
@aherrmann
test-cases for allocatePartyWithHint(On)
23ea84c
@aherrmann-da aherrmann-da added this to the DAML Script milestone Feb 12, 2020
cocreature
cocreature approved these changes Feb 12, 2020
View reviewed changes
Copy link
Contributor

@cocreature cocreature left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks for addressing this so quickly!

daml-script/daml/Daml/Script.daml Outdated Show resolved Hide resolved
daml-script/daml/Daml/Script.daml Outdated Show resolved Hide resolved
daml-script/daml/Daml/Script.daml Outdated Show resolved Hide resolved
@mergify mergify bot merged commit a44e009 into master Feb 12, 2020
@mergify mergify bot deleted the alloc-party-with branch February 12, 2020 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cocreature cocreature cocreature approved these changes

@hurryabit hurryabit Awaiting requested review from hurryabit

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Daml Script
Development

Successfully merging this pull request may close these issues.

Add allocatePartyWithHint and allocatePartyWithHintOn to DAML script
3 participants
@aherrmann-da @cocreature @aherrmann