Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the flaky ledger-on-sql test on Windows. #4402

Merged
merged 4 commits into from
Feb 5, 2020

Conversation

ghost
Copy link

@ghost ghost commented Feb 5, 2020

Turns out this is just due to a very short MRT window in the KVUtils integration tests. (test start time + 1 second) is fine for a fast machine, but on a slow machine with a lot going on, it's too tight.

I've increased it to 10 seconds. I also refactored the way we compute them to make sure it's readable, because I find it difficult to figure out how long (1 followed by lots of zeroes) microseconds is in human-comprehensible time durations.

Pull Request Checklist

  • Read and understand the contribution guidelines
  • Include appropriate tests
  • Set a descriptive title and thorough description
  • Add a reference to the issue this PR will solve, if appropriate
  • Include changelog additions in one or more commit message bodies between the CHANGELOG_BEGIN and CHANGELOG_END tags
  • Normal production system change, include purpose of change in description

NOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with /AzurePipelines run to
trigger the build.

Copy link
Collaborator

@remyhaemmerle-da remyhaemmerle-da left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks

@ghost ghost added the automerge label Feb 5, 2020
@mergify mergify bot merged commit 784a90b into master Feb 5, 2020
@mergify mergify bot deleted the ledger/ledger-on-sql/fix-flaky-tests branch February 5, 2020 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants