Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to haskell-lsp 0.20 #4397

Merged
merged 2 commits into from
Feb 5, 2020
Merged

Upgrade to haskell-lsp 0.20 #4397

merged 2 commits into from
Feb 5, 2020

Conversation

cocreature
Copy link
Contributor

This includes another ghcide bump but the only change there is the
haskell-lsp ugprade. haskell-lsp 0.20 includes some performance
improvements.

changelog_begin
changelog_end

Pull Request Checklist

  • Read and understand the contribution guidelines
  • Include appropriate tests
  • Set a descriptive title and thorough description
  • Add a reference to the issue this PR will solve, if appropriate
  • Include changelog additions in one or more commit message bodies between the CHANGELOG_BEGIN and CHANGELOG_END tags
  • Normal production system change, include purpose of change in description

NOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with /AzurePipelines run to
trigger the build.

@cocreature
Upgrade to haskell-lsp 0.20
5b446d0 
This includes another ghcide bump but the only change there is the
haskell-lsp ugprade. haskell-lsp 0.20 includes some performance
improvements.

changelog_begin
changelog_end
@cocreature cocreature requested review from a user and aherrmann-da February 5, 2020 09:19
aherrmann-da
aherrmann-da approved these changes Feb 5, 2020
View reviewed changes
Copy link
Contributor

@aherrmann-da aherrmann-da left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

CI:
Encountered missing dependencies:

parser-combinators >=1.2

@cocreature cocreature merged commit 959da4c into master Feb 5, 2020
@cocreature cocreature deleted the upgrade-haskell-lsp branch February 5, 2020 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aherrmann-da aherrmann-da aherrmann-da approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cocreature @aherrmann-da