Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flip the default on mavenUpload in artifacts.yaml #4396

Merged
merged 1 commit into from
Feb 5, 2020
Merged

Flip the default on mavenUpload in artifacts.yaml #4396

merged 1 commit into from
Feb 5, 2020

Conversation

cocreature
Copy link
Contributor

changelog_begin
changelog_end

Pull Request Checklist

  • Read and understand the contribution guidelines
  • Include appropriate tests
  • Set a descriptive title and thorough description
  • Add a reference to the issue this PR will solve, if appropriate
  • Include changelog additions in one or more commit message bodies between the CHANGELOG_BEGIN and CHANGELOG_END tags
  • Normal production system change, include purpose of change in description

NOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with /AzurePipelines run to
trigger the build.

cocreature
cocreature commented Feb 5, 2020
View reviewed changes
release/artifacts.yaml
- target: //ledger/participant-state/kvutils:kvutils
type: jar-scala
mavenUpload: true
- target: //ledger-service/lf-value-json:lf-value-json
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This meanslf-value-json, utils, db-backend and http-json are now uploaded. Happy to change any of that. Afaict this is the only change.

@ghost
Copy link

ghost commented Feb 5, 2020

YES.

gerolf-da
gerolf-da approved these changes Feb 5, 2020
View reviewed changes
Copy link
Contributor

@gerolf-da gerolf-da left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot, @cocreature!

@cocreature cocreature merged commit bd127d6 into master Feb 5, 2020
@cocreature cocreature deleted the maven-default branch February 5, 2020 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gerolf-da gerolf-da gerolf-da approved these changes

@stefanobaghino-da stefanobaghino-da Awaiting requested review from stefanobaghino-da

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cocreature @gerolf-da