Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to Bazel 2.0.0 #4352

Merged
merged 4 commits into from
Feb 7, 2020
Merged

Update to Bazel 2.0.0 #4352

merged 4 commits into from
Feb 7, 2020

Conversation

aherrmann-da
Copy link
Contributor

@aherrmann-da aherrmann-da commented Feb 3, 2020 •
edited
Loading

  • Updates Bazel in the Windows dev-env
  • Updates nixpkgs to update Bazel
  • Pin sphinx at 1.8.3 as the new 2.2.2 in nixpkgs causes build failures in //docs:pdf-docs.

Pull Request Checklist

  • Read and understand the contribution guidelines
  • Include appropriate tests
  • Set a descriptive title and thorough description
  • Add a reference to the issue this PR will solve, if appropriate
  • Include changelog additions in one or more commit message bodies between the CHANGELOG_BEGIN and CHANGELOG_END tags
  • Normal production system change, include purpose of change in description

NOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with /AzurePipelines run to
trigger the build.

@aherrmann-da aherrmann-da marked this pull request as ready for review February 7, 2020 10:56
cocreature
cocreature approved these changes Feb 7, 2020
View reviewed changes
Copy link
Contributor

@cocreature cocreature left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you!

nix/nixpkgs.nix
@@ -17,6 +17,7 @@ let
sha256 = "1jcyd9jy7kz5zfch25s4inwlivb1y1w52fzfjy5ra5vcnp3hmqyr";
fetchSubmodules = true;
};
patches = [];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don’t need this do we?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added a comment to clarify. Upstream nixpkgs adds patches that are incompatible with our version override.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah I see, thanks for the explanation!

@mergify mergify bot merged commit fdeca38 into master Feb 7, 2020
@mergify mergify bot deleted the bazel-update branch February 7, 2020 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cocreature cocreature cocreature approved these changes

@garyverhaegen-da garyverhaegen-da Awaiting requested review from garyverhaegen-da

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aherrmann-da @cocreature @aherrmann