Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix release script #4275

Merged
4 commits merged into from
Jan 30, 2020
Merged

fix release script #4275

4 commits merged into from
Jan 30, 2020

Conversation

ghost
Copy link

@ghost ghost commented Jan 29, 2020

only upload from the linux machine and escape arguments to publish,
otherwise they get interpreted by bazel.

CHANGELOG_BEGIN
CHANGELOG_END

Pull Request Checklist

  • Read and understand the contribution guidelines
  • Include appropriate tests
  • Set a descriptive title and thorough description
  • Add a reference to the issue this PR will solve, if appropriate
  • Include changelog additions in one or more commit message bodies between the CHANGELOG_BEGIN and CHANGELOG_END tags
  • Normal production system change, include purpose of change in description

NOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with /AzurePipelines run to
trigger the build.

fix release script
d806f06 
only upload from the linux machine and escape arguments to `publish`,
otherwise they get interpreted by bazel.

CHANGELOG_BEGIN
CHANGELOG_END
cocreature
cocreature approved these changes Jan 29, 2020
View reviewed changes
Copy link
Contributor

@cocreature cocreature left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

release/src/Main.hs Outdated Show resolved Hide resolved
release/src/Main.hs Outdated Show resolved Hide resolved
release/src/Main.hs Outdated Show resolved Hide resolved
Robin Krom and others added 3 commits January 30, 2020 10:01
@cocreature
Update release/src/Main.hs
4f84d60 
Co-Authored-By: Moritz Kiefer <moritz.kiefer@purelyfunctional.org>
@cocreature
Update release/src/Main.hs
84150cd 
Co-Authored-By: Moritz Kiefer <moritz.kiefer@purelyfunctional.org>
bracket -> bracket_
a259f2c
@ghost ghost merged commit eacacbf into master Jan 30, 2020
@ghost ghost deleted the fix_release_2 branch January 30, 2020 09:51
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@cocreature