ledger-on-sql: Make sure the ledger picks up where it left off. #4266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This means seeding the dispatcher with the correct head, rather than starting at 1 every time. CHANGELOG_BEGIN CHANGELOG_END
They're used everywhere.
SamirTalwar
requested review from
gerolf-da,
rautenrieth-da and
stefanobaghino-da
as code owners
stefanobaghino-da
approved these changes
Jan 29, 2020
ledger/ledger-on-sql/src/main/scala/com/daml/ledger/on/sql/package.scala
Show resolved
Hide resolved
ledger/ledger-on-sql/src/test/suite/scala/com/daml/ledger/on/sql/RestartSpec.scala
Show resolved
Hide resolved
mergify
bot
deleted the
ledger/ledger-on-sql/restart-where-we-left-off
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This means seeding the dispatcher with the correct head, rather than starting at 1 every time.
I'd like to move the test case into
ParticipantStateIntegrationSpecBase, but it's going to require more thought around acquiring and releasing the participant state resource.Closes #4223.
Pull Request Checklist
CHANGELOG_BEGINandCHANGELOG_ENDtagsNOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with
/AzurePipelines runtotrigger the build.