Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate daml2ts into the assistant #4252

Merged
merged 1 commit into from
Jan 28, 2020
Merged

Integrate daml2ts into the assistant #4252

merged 1 commit into from
Jan 28, 2020

Conversation

shayne-fletcher
Copy link
Contributor

Generate TypeScript bindings to DAML with daml codegen ts DAR -o OUTDIR.

@shayne-fletcher shayne-fletcher requested a review from a user January 28, 2020 20:20
@shayne-fletcher shayne-fletcher force-pushed the daml2ts-sdk-integration branch 2 times, most recently from 3803df4 to 5bfa7d7 Compare January 28, 2020 20:25
cocreature
cocreature approved these changes Jan 28, 2020
View reviewed changes
Copy link
Contributor

@cocreature cocreature left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice thank you! Some minor comments on the SDK config.

release/sdk-config.yaml.tmpl Show resolved Hide resolved
release/sdk-config.yaml.tmpl Outdated Show resolved Hide resolved
@shayne-fletcher
Integrate daml2ts into the assistant
48cde19 
changelog_begin
- Generate TypeScript bindings to DAML with `daml codegen ts DAR -o OUTDIR`
changelog_end
@shayne-fletcher shayne-fletcher force-pushed the daml2ts-sdk-integration branch from 5bfa7d7 to 48cde19 Compare January 28, 2020 21:38
@mergify mergify bot merged commit 0e53ec0 into master Jan 28, 2020
@mergify mergify bot deleted the daml2ts-sdk-integration branch January 28, 2020 22:03
@hurryabit
Copy link
Contributor

Very nice. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cocreature cocreature cocreature approved these changes

Assignees
No one assigned
Labels
component/packaging language/now Language team priority NOW
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shayne-fletcher @hurryabit @cocreature