Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing CurrentSdk prefixes in data-dependencies #4220

Merged
merged 2 commits into from
Jan 27, 2020

Conversation

ghost
Copy link

@ghost ghost commented Jan 27, 2020

This should fix the errors in #4219

associahedron added 2 commits January 27, 2020 10:22
Also add some type signatures.

changelog_begin
changelog_end
@ghost ghost requested a review from cocreature January 27, 2020 11:17
@ghost ghost requested a review from hurryabit as a code owner January 27, 2020 11:17
Copy link
Contributor

@cocreature cocreature left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks a lot for the quick fix!

I tested #4219 with this and it does indeed fix the issue 🎉

@cocreature cocreature merged commit 830c2c6 into master Jan 27, 2020
@cocreature cocreature deleted the expose-scenarios branch January 27, 2020 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant