Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing module refs issue #4211

Merged
merged 1 commit into from
Jan 24, 2020
Merged

Fix missing module refs issue #4211

merged 1 commit into from
Jan 24, 2020

Conversation

shayne-fletcher
Copy link
Contributor

Fixes an issue whereby if a choice return type comes from an external module, a reference to that module was not being respected in the generated TypeScript.

Copy link
Contributor

@rohanjr rohanjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good, can you add to the tests to exercise this?

@shayne-fletcher shayne-fletcher force-pushed the daml2ts-import-refs-fix branch from aa82e3d to d20be36 Compare January 24, 2020 21:00
@shayne-fletcher
Copy link
Contributor Author

Change looks good, can you add to the tests to exercise this?

Yes, added.

@shayne-fletcher shayne-fletcher force-pushed the daml2ts-import-refs-fix branch 2 times, most recently from 892804e to 4d5d524 Compare January 24, 2020 21:07
changelog_begin
changelog_end
Copy link
Contributor

@hurryabit hurryabit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome. Thanks so much!

@mergify mergify bot merged commit 2160ad5 into master Jan 24, 2020
@mergify mergify bot deleted the daml2ts-import-refs-fix branch January 24, 2020 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants