Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change Exercise by Key to send ExerciseByKeyCommand #4209

Merged
merged 1 commit into from
Jan 24, 2020
Merged

Change Exercise by Key to send ExerciseByKeyCommand #4209

merged 1 commit into from
Jan 24, 2020

Conversation

leo-da
Copy link
Contributor

@leo-da leo-da commented Jan 24, 2020 •
edited
Loading

instead of lookup by key + ExerciseCommand with retrieved contract ID.

Closes: #4081

Pull Request Checklist

  • Read and understand the contribution guidelines
  • Include appropriate tests
  • Set a descriptive title and thorough description
  • Add a reference to the issue this PR will solve, if appropriate
  • Include changelog additions in one or more commit message bodies between the CHANGELOG_BEGIN and CHANGELOG_END tags
  • Normal production system change, include purpose of change in description

NOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with /AzurePipelines run to
trigger the build.

@leo-da leo-da force-pushed the leo-4081-exercise-by-key-cmd branch from 930218a to 3424191 Compare January 24, 2020 16:21
@leo-da
Change Exercise by Key to send ExerciseByKeyCommand
ec3f2fe 
instead of lookup by key + ExerciseCommand with retrieved contract ID.

CHANGELOG_BEGIN
CHANGELOG_END
@leo-da leo-da force-pushed the leo-4081-exercise-by-key-cmd branch from 3424191 to ec3f2fe Compare January 24, 2020 16:25
gerolf-da
gerolf-da approved these changes Jan 24, 2020
View reviewed changes
Copy link
Contributor

@gerolf-da gerolf-da left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@leo-da
Copy link
Contributor Author

leo-da commented Jan 24, 2020

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 1 pipeline(s).

@mergify mergify bot merged commit 231b9c6 into master Jan 24, 2020
@mergify mergify bot deleted the leo-4081-exercise-by-key-cmd branch January 24, 2020 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gerolf-da gerolf-da gerolf-da approved these changes

@S11001001 S11001001 Awaiting requested review from S11001001

@hurryabit hurryabit Awaiting requested review from hurryabit

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change Exercise by Key to submit ExerciseByKeyCommand
2 participants
@leo-da @gerolf-da