Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

daml-types.ts: Lint tests as well #4208

Merged
merged 2 commits into from
Jan 25, 2020
Merged

daml-types.ts: Lint tests as well #4208

merged 2 commits into from
Jan 25, 2020

Conversation

hurryabit
Copy link
Contributor

@hurryabit hurryabit commented Jan 24, 2020 •
edited
Loading

Also simplify file selection a bit.

CHANGELOG_BEGIN
CHANGELOG_END

Pull Request Checklist

  • Read and understand the contribution guidelines
  • Include appropriate tests
  • Set a descriptive title and thorough description
  • Add a reference to the issue this PR will solve, if appropriate
  • Include changelog additions in one or more commit message bodies between the CHANGELOG_BEGIN and CHANGELOG_END tags
  • Normal production system change, include purpose of change in description

NOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with /AzurePipelines run to
trigger the build.

This change is Reviewable

@hurryabit hurryabit requested review from a user and aherrmann-da January 24, 2020 16:13
aherrmann-da
aherrmann-da approved these changes Jan 24, 2020
View reviewed changes
Copy link
Contributor

@aherrmann-da aherrmann-da left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hurryabit
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 1 pipeline(s).

@hurryabit hurryabit force-pushed the daml-types-lint-tests branch from aab4c39 to f3b7a1f Compare January 24, 2020 21:48
@hurryabit
daml-types.ts: Lint tests as well
56a68d0 
Also simplify file selection a bit.

CHANGELOG_BEGIN
CHANGELOG_END
@hurryabit hurryabit force-pushed the daml-types-lint-tests branch from f3b7a1f to 56a68d0 Compare January 24, 2020 21:49
@hurryabit
Fix build command in test script
0b731da 
CHANGELOG_BEGIN
CHANGELOG_END
@mergify mergify bot merged commit 8b7878f into master Jan 25, 2020
@mergify mergify bot deleted the daml-types-lint-tests branch January 25, 2020 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aherrmann-da aherrmann-da aherrmann-da approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hurryabit @aherrmann-da