Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Engine: make Node.isReplayedBy public #4206

Merged
merged 1 commit into from
Jan 24, 2020
Merged

Engine: make Node.isReplayedBy public #4206

merged 1 commit into from
Jan 24, 2020

Conversation

remyhaemmerle-da
Copy link
Collaborator

We make public the methods isReplayedBy from Node and GenTransaction

This allows external code to validate transactions.

Pull Request Checklist

  • Read and understand the contribution guidelines
  • Include appropriate tests
  • Set a descriptive title and thorough description
  • Add a reference to the issue this PR will solve, if appropriate
  • Include changelog additions in one or more commit message bodies between the CHANGELOG_BEGIN and CHANGELOG_END tags
  • Normal production system change, include purpose of change in description

NOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with /AzurePipelines run to
trigger the build.

@remyhaemmerle-da remyhaemmerle-da added the component/daml-engine DAML-LF Engine & Interpreter label Jan 24, 2020
@remyhaemmerle-da remyhaemmerle-da added this to the Maintenance milestone Jan 24, 2020
@remyhaemmerle-da remyhaemmerle-da requested review from a user and gerolf-da January 24, 2020 14:15
CHANGELOG_BEGIN
CHANGELOG_END
@remyhaemmerle-da
Copy link
Collaborator Author

cc @phoebe-da

@mergify mergify bot merged commit 40ea33c into master Jan 24, 2020
@mergify mergify bot deleted the isReplayBy-public branch January 24, 2020 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/daml-engine DAML-LF Engine & Interpreter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants