Add logging context information to ledger services #4205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefanobaghino-da
requested review from
gerolf-da,
rautenrieth-da and
SamirTalwar
as code owners
stefanobaghino-da
force-pushed
the
3699
branch
from
327de62 to
b3f12b0
Compare
Rolls back that AllowedType implicit, which made the logging context less usable and didn't provide that much of an advantage. Replaced with helpers where it makes sense that take care of turning the value safely into a string. Closes #3699 CHANGELOG_BEGIN CHANGELOG_END
stefanobaghino-da
force-pushed
the
3699
branch
from
b3f12b0 to
d2771a9
Compare
SamirTalwar
approved these changes
Jan 24, 2020
.../sandbox/src/main/scala/com/digitalasset/platform/apiserver/services/ApiCommandService.scala
Show resolved
Hide resolved
|
Closed by mistake, I'll put my fingers on a diet. 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rolls back that AllowedType implicit, which made the logging context
less usable and didn't provide that much of an advantage. Replaced with
helpers where it makes sense that take care of turning the value safely
into a string.
Closes #3699
CHANGELOG_BEGIN
CHANGELOG_END
Pull Request Checklist
CHANGELOG_BEGINandCHANGELOG_ENDtagsNOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with
/AzurePipelines runtotrigger the build.