Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ledger-on-sql: PostgreSQL support. #4204

Merged
merged 11 commits into from
Jan 24, 2020
Merged

ledger-on-sql: PostgreSQL support. #4204

merged 11 commits into from
Jan 24, 2020

Conversation

SamirTalwar
Copy link
Contributor

Run DAML-on-SQL against PostgreSQL. 😄

Closes #4038.

Pull Request Checklist

  • Read and understand the contribution guidelines
  • Include appropriate tests
  • Set a descriptive title and thorough description
  • Add a reference to the issue this PR will solve, if appropriate
  • Include changelog additions in one or more commit message bodies between the CHANGELOG_BEGIN and CHANGELOG_END tags
  • Normal production system change, include purpose of change in description

NOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with /AzurePipelines run to
trigger the build.

@SamirTalwar
ledger-on-sql: Don't bother cleaning up after integration tests.
834d6b2 
Turns out Bazel cleans up before each test run, so we only have one
set of outputs at a time. This is far more useful for debugging anyway.
@SamirTalwar
ledger-on-sql: Pull out a test-lib to simplify the conformance tests.
a2d6e8b
@SamirTalwar
ledger-on-sql: Turn Database from a sealed trait into a case class.
aa7c024
@SamirTalwar
ledger-on-sql: Support for PostgreSQL!
b007e76 
CHANGELOG_BEGIN
CHANGELOG_END
@SamirTalwar
ledger-on-sql: Run the conformance tests against PostgreSQL.
690a189
@SamirTalwar
ledger-on-sql: Run the LotsOfParties conformance tests.
71804a4
@SamirTalwar
ledger-on-sql: Use PostgreSQL's RETURNING keyword to save a query.
75212bc
@SamirTalwar
ledger-on-sql: Ensure the reader connection pool is read-only.
873bde9
@SamirTalwar
ledger-on-sql: Avoid cloning ByteStrings as byte arrays where possible.
754912f 
Instead, use `ByteString#newInput()`, which returns an `InputStream`.
This is supported by H2 and PostgreSQL, but unfortunately not SQLite.
@SamirTalwar
ledger-on-sql: Run integration tests in parallel.
d586f82
gerolf-da
gerolf-da approved these changes Jan 24, 2020
View reviewed changes
Copy link
Contributor

@gerolf-da gerolf-da left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's AWESOME! 🎉

@SamirTalwar SamirTalwar merged commit 0be3e72 into master Jan 24, 2020
@SamirTalwar SamirTalwar deleted the ledger/ledger-on-sql/postgresql-support branch January 24, 2020 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gerolf-da gerolf-da gerolf-da approved these changes

@rautenrieth-da rautenrieth-da Awaiting requested review from rautenrieth-da

@stefanobaghino-da stefanobaghino-da Awaiting requested review from stefanobaghino-da

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add postgres backend to KV SQL Ledger
2 participants
@SamirTalwar @gerolf-da