Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

daml-ledger.ts: Simplify types of *ByKey operations #4202

Merged
merged 1 commit into from
Jan 24, 2020
Merged

daml-ledger.ts: Simplify types of *ByKey operations #4202

merged 1 commit into from
Jan 24, 2020

Conversation

hurryabit
Copy link
Contributor

@hurryabit hurryabit commented Jan 24, 2020 •
edited
Loading

The current type signature adds complexity which is unjustified in my
opinion. Who would expect meaningful results when specifying a template
by key undefined?

CHANGELOG_BEGIN
CHANGELOG_END

Pull Request Checklist

  • Read and understand the contribution guidelines
  • Include appropriate tests
  • Set a descriptive title and thorough description
  • Add a reference to the issue this PR will solve, if appropriate
  • Include changelog additions in one or more commit message bodies between the CHANGELOG_BEGIN and CHANGELOG_END tags
  • Normal production system change, include purpose of change in description

NOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with /AzurePipelines run to
trigger the build.

This change is Reviewable

@hurryabit
daml-ledger.ts: Simplify types of *ByKey operations
064ff34 
The current type signature adds complexity which is unjustified in my
opinion. Who would expect meaningful results when specifying a template
by key `undefined`?

CHANGELOG_BEGIN
CHANGELOG_END
@hurryabit hurryabit requested a review from a user January 24, 2020 10:14
ghost
ghost approved these changes Jan 24, 2020
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense.

@mergify mergify bot merged commit 3a4d356 into master Jan 24, 2020
@mergify mergify bot deleted the daml-fetch-simplify-by-key branch January 24, 2020 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@hurryabit