Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

daml-ledger.ts: Rename create argument to payload #4198

Merged
merged 1 commit into from
Jan 24, 2020
Merged

daml-ledger.ts: Rename create argument to payload #4198

merged 1 commit into from
Jan 24, 2020

Conversation

hurryabit
Copy link
Contributor

@hurryabit hurryabit commented Jan 24, 2020 •
edited
Loading

This is better in line with the field name of the CreatedEvent you'll
receive as a result of calling this.

CHANGELOG_BEGIN
CHANGELOG_END

Pull Request Checklist

  • Read and understand the contribution guidelines
  • Include appropriate tests
  • Set a descriptive title and thorough description
  • Add a reference to the issue this PR will solve, if appropriate
  • Include changelog additions in one or more commit message bodies between the CHANGELOG_BEGIN and CHANGELOG_END tags
  • Normal production system change, include purpose of change in description

NOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with /AzurePipelines run to
trigger the build.

This change is Reviewable

@hurryabit
daml-ledger.ts: Rename create argument to payload
a9ff085 
This is better in line with the field name of the `CreatedEvent` you'll
receive as a result of calling this.

CHANGELOG_BEGIN
CHANGELOG_END
@hurryabit hurryabit requested a review from a user January 24, 2020 08:16
cocreature
cocreature approved these changes Jan 24, 2020
View reviewed changes
Copy link
Contributor

@cocreature cocreature left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mergify mergify bot merged commit 183df61 into master Jan 24, 2020
@mergify mergify bot deleted the daml-ledger-create-payload branch January 24, 2020 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cocreature cocreature cocreature approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hurryabit @cocreature