Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

postgresql-testing: Extract PostgresAround from the Sandbox t… #4197

Merged

Conversation

SamirTalwar
Copy link
Contributor

This moves PostgresAround into its own library in libs-scala/postgresql-testing so that ledger/ledger-on-sql, among others, doesn't have to depend on Sandbox.

Pull Request Checklist

  • Read and understand the contribution guidelines
  • Include appropriate tests
  • Set a descriptive title and thorough description
  • Add a reference to the issue this PR will solve, if appropriate
  • Include changelog additions in one or more commit message bodies between the CHANGELOG_BEGIN and CHANGELOG_END tags
  • Normal production system change, include purpose of change in description

NOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with /AzurePipelines run to
trigger the build.

Copy link
Contributor

@gerolf-da gerolf-da left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thank you!

@SamirTalwar SamirTalwar changed the title postgresql-testing: Extract PostgresAround from the Sandbox tests. postgresql-testing: Extract PostgresAround from the Sandbox t… Jan 24, 2020
@SamirTalwar SamirTalwar merged commit f3f7def into master Jan 24, 2020
@SamirTalwar SamirTalwar deleted the libs-scala/postgresql-testing/extract-from-sandbox-tests branch January 24, 2020 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants