Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct rename to "daml-ledger" #4195

Merged
merged 1 commit into from
Jan 24, 2020
Merged

Correct rename to "daml-ledger" #4195

merged 1 commit into from
Jan 24, 2020

Conversation

rohanjr
Copy link
Contributor

@rohanjr rohanjr commented Jan 23, 2020

Pull Request Checklist

  • Read and understand the contribution guidelines
  • Include appropriate tests
  • Set a descriptive title and thorough description
  • Add a reference to the issue this PR will solve, if appropriate
  • Include changelog additions in one or more commit message bodies between the CHANGELOG_BEGIN and CHANGELOG_END tags
  • Normal production system change, include purpose of change in description

NOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with /AzurePipelines run to
trigger the build.

@rohanjr rohanjr requested a review from a user January 23, 2020 21:27
@rohanjr rohanjr self-assigned this Jan 23, 2020
@rohanjr rohanjr mentioned this pull request Jan 23, 2020
Merged
6 tasks
@rohanjr
Correct rename to "daml-ledger"
554b02a 
CHANGELOG_BEGIN
CHANGELOG_END
@rohanjr rohanjr force-pushed the daml-ledger-rename branch from 30cae04 to 554b02a Compare January 23, 2020 21:30
cocreature
cocreature approved these changes Jan 24, 2020
View reviewed changes
Copy link
Contributor

@cocreature cocreature left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks!

hurryabit
hurryabit approved these changes Jan 24, 2020
View reviewed changes
Copy link
Contributor

@hurryabit hurryabit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch. Thank you.

@hurryabit hurryabit merged commit 63660c6 into master Jan 24, 2020
@hurryabit hurryabit deleted the daml-ledger-rename branch January 24, 2020 08:00
@ghost
Copy link

ghost commented Jan 27, 2020

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hurryabit hurryabit hurryabit approved these changes

@cocreature cocreature cocreature approved these changes

Assignees

@rohanjr rohanjr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rohanjr @cocreature @hurryabit