Rename argument field to payload in the command/create request
#4192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[JSON API - Experimental] Rename ``argument`` field to ``payload`` in the ``command/create`` request. See #4189. CHANGELOG_END
S11001001
reviewed
Jan 23, 2020
| @@ -154,12 +154,12 @@ class Ledger { | |||
| /** | |||
| * Create a contract for a given template. | |||
| */ | |||
| async create<T extends object, K>(template: Template<T, K>, argument: T): Promise<CreateEvent<T, K>> { | |||
| const payload = { | |||
| async create<T extends object, K>(template: Template<T, K>, contractPayload: T): Promise<CreateEvent<T, K>> { | |||
There was a problem hiding this comment.
Suggested change
| async create<T extends object, K>(template: Template<T, K>, contractPayload: T): Promise<CreateEvent<T, K>> { | |
| async create<T extends object, K>(template: Template<T, K>, payload: T): Promise<CreateEvent<T, K>> { |
Seems more in the spirit of the change, no?
| templateId: template.templateId, | ||
| argument, | ||
| payload: contractPayload, |
There was a problem hiding this comment.
Suggested change
| payload: contractPayload, | |
| payload, |
There was a problem hiding this comment.
I guess, it is just in a few other places, @hurryabit refers to the entire command as a payload.
There was a problem hiding this comment.
Fair, well, whatever you think is best.
S11001001
approved these changes
Jan 23, 2020
hurryabit
approved these changes
Jan 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename
argumentfield topayloadin thecommand/createrequest.Closes: #4189
Pull Request Checklist
CHANGELOG_BEGINandCHANGELOG_ENDtagsNOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with
/AzurePipelines runtotrigger the build.