Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More DAML LF type synonym validation tests #4181

Merged
merged 3 commits into from
Jan 24, 2020
Merged

More DAML LF type synonym validation tests #4181

merged 3 commits into from
Jan 24, 2020

Conversation

nickchapman-da
Copy link
Contributor

More DAML LF type synonym validation tests

  • negative tests for badly formed synonym applications
  • check synonym definitions & test (positive/negative)

Pull Request Checklist

  • Read and understand the contribution guidelines
  • Include appropriate tests
  • Set a descriptive title and thorough description
  • Add a reference to the issue this PR will solve, if appropriate
  • Include changelog additions in one or more commit message bodies between the CHANGELOG_BEGIN and CHANGELOG_END tags
  • Normal production system change, include purpose of change in description

NOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with /AzurePipelines run to
trigger the build.

@nickchapman-da
check type synonym definitions are well formed
42e9031 
changelog_begin
changelog_end
@nickchapman-da nickchapman-da force-pushed the more-type-syn-validation-tests branch from acb1602 to 42e9031 Compare January 23, 2020 14:17
cocreature
cocreature approved these changes Jan 23, 2020
View reviewed changes
Copy link
Contributor

@cocreature cocreature left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you!

daml-lf/validation/src/test/scala/com/digitalasset/daml/lf/validation/TypingSpec.scala Outdated Show resolved Hide resolved
remyhaemmerle-da
remyhaemmerle-da approved these changes Jan 23, 2020
View reviewed changes
Copy link
Collaborator

@remyhaemmerle-da remyhaemmerle-da left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@nickchapman-da @cocreature
Update daml-lf/validation/src/test/scala/com/digitalasset/daml/lf/val…
7ecb596 
…idation/TypingSpec.scala

Co-Authored-By: Moritz Kiefer <moritz.kiefer@purelyfunctional.org>
@nickchapman-da
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 1 pipeline(s).

@nickchapman-da nickchapman-da merged commit 706464d into master Jan 24, 2020
@nickchapman-da nickchapman-da deleted the more-type-syn-validation-tests branch January 24, 2020 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@remyhaemmerle-da remyhaemmerle-da remyhaemmerle-da approved these changes

@cocreature cocreature cocreature approved these changes

@leo-da leo-da Awaiting requested review from leo-da

@S11001001 S11001001 Awaiting requested review from S11001001

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nickchapman-da @cocreature @remyhaemmerle-da