Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rename typescript language support libs #4180

Merged
1 commit merged into from
Jan 23, 2020
Merged

rename typescript language support libs #4180

1 commit merged into from
Jan 23, 2020

Conversation

ghost
Copy link

@ghost ghost commented Jan 23, 2020

We rename the typescript packages of the language support as follows:
@digitalasset/daml-json-types -> @daml/types
@digitalasset/daml-ledger-fetch -> @daml/ledger

Pull Request Checklist

  • Read and understand the contribution guidelines
  • Include appropriate tests
  • Set a descriptive title and thorough description
  • Add a reference to the issue this PR will solve, if appropriate
  • Include changelog additions in one or more commit message bodies between the CHANGELOG_BEGIN and CHANGELOG_END tags
  • Normal production system change, include purpose of change in description

NOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with /AzurePipelines run to
trigger the build.

rename typescript language support libs
d2b3485 
We rename the typescript packages of the language support as follows:
  @digitalasset/daml-json-types -> @daml/types
  @digitalasset/daml-ledger-fetch -> @daml/ledger

CHANGELOG_BEGIN
CHANGELOG_END
hurryabit
hurryabit approved these changes Jan 23, 2020
View reviewed changes
Copy link
Contributor

@hurryabit hurryabit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

FYI @rohanjr for create-daml-app.

@ghost ghost merged commit a3de2fb into master Jan 23, 2020
@ghost ghost deleted the rename_ts_libraries branch January 23, 2020 15:14
rohanjr
rohanjr reviewed Jan 23, 2020
View reviewed changes
language-support/ts/package.json
"daml-json-types",
"daml-ledger-fetch"
"daml-types",
"daml-fetch"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this "daml-ledger" now?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed in #4195 if correct

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rohanjr @hurryabit