Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci cron: tell Slack on failure #4179

Merged
merged 1 commit into from
Jan 23, 2020
Merged

ci cron: tell Slack on failure #4179

merged 1 commit into from
Jan 23, 2020

Conversation

garyverhaegen-da
Copy link
Contributor

Currently, when cron jobs fail, this is completely silent. After #4178, in which we realized the VSCode extension had not been updated for about a month, I believe it may be a good idea to get error messages sent to Slack when a cron job fails.

We'll need to monitor for verbosity, but hopefully they will work most of the time.

@garyverhaegen-da
ci cron: tell Slack on failure
a611d20 
Currently, when cron jobs fail, this is completely silent. After #4178,
in which we realized the VSCode extension had not been updated for about
a month, I believe it may be a good idea to get error messages sent to
Slack when a cron job fails.

We'll need to monitor for verbosity, but hopefully they will work most
of the time.

CHANGELOG_BEGIN
CHANGELOG_END
hurryabit
hurryabit approved these changes Jan 23, 2020
View reviewed changes
Copy link
Contributor

@hurryabit hurryabit left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great initiative. Thanks a lot.

Did you mean to check in ci/tell-slack-failed.yml as well?

cocreature
cocreature approved these changes Jan 23, 2020
View reviewed changes
Copy link
Contributor

@cocreature cocreature left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@hurryabit That file is already checked in.

@garyverhaegen-da garyverhaegen-da merged commit 9d8e8d4 into master Jan 23, 2020
@garyverhaegen-da garyverhaegen-da deleted the warn-on-cron-failure branch January 23, 2020 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hurryabit hurryabit hurryabit approved these changes

@cocreature cocreature cocreature approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@garyverhaegen-da @cocreature @hurryabit