Fix yarn target in VSCode ext cron job #4178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This has changed in 0a26591 which broke the build. We only build the latest release so changing this should be safe and not break older releases. changelog_begin changelog_end
garyverhaegen-da
added a commit
that referenced
this pull request
Jan 23, 2020
Currently, when cron jobs fail, this is completely silent. After #4178, in which we realized the VSCode extension had not been updated for about a month, I believe it may be a good idea to get error messages sent to Slack when a cron job fails. We'll need to monitor for verbosity, but hopefully they will work most of the time. CHANGELOG_BEGIN CHANGELOG_END
garyverhaegen-da
added a commit
that referenced
this pull request
Jan 23, 2020
Currently, when cron jobs fail, this is completely silent. After #4178, in which we realized the VSCode extension had not been updated for about a month, I believe it may be a good idea to get error messages sent to Slack when a cron job fails. We'll need to monitor for verbosity, but hopefully they will work most of the time. CHANGELOG_BEGIN CHANGELOG_END
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has changed in 0a26591 which
broke the build. We only build the latest release so changing this
should be safe and not break older releases.
changelog_begin
changelog_end
Pull Request Checklist
CHANGELOG_BEGINandCHANGELOG_ENDtagsNOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with
/AzurePipelines runtotrigger the build.