Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump ghcide to fix GHC panics in LSP tests #4176

Merged
merged 1 commit into from
Jan 24, 2020
Merged

Bump ghcide to fix GHC panics in LSP tests #4176

merged 1 commit into from
Jan 24, 2020

Conversation

cocreature
Copy link
Contributor

@cocreature cocreature commented Jan 23, 2020 •
edited
Loading

fixes #4152

changelog_begin
changelog_end

Pull Request Checklist

  • Read and understand the contribution guidelines
  • Include appropriate tests
  • Set a descriptive title and thorough description
  • Add a reference to the issue this PR will solve, if appropriate
  • Include changelog additions in one or more commit message bodies between the CHANGELOG_BEGIN and CHANGELOG_END tags
  • Normal production system change, include purpose of change in description

NOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with /AzurePipelines run to
trigger the build.

shayne-fletcher
shayne-fletcher approved these changes Jan 23, 2020
View reviewed changes
Copy link
Contributor

@shayne-fletcher shayne-fletcher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ohrrn

@cocreature cocreature force-pushed the debug-lsp-tests branch 2 times, most recently from d3f263e to 7a880e4 Compare January 23, 2020 16:44
@cocreature cocreature changed the title debug lsp tests Bump ghcide to fix GHC panics in LSP tests Jan 23, 2020
@cocreature cocreature marked this pull request as ready for review January 23, 2020 16:46
@cocreature cocreature requested a review from hurryabit as a code owner January 23, 2020 16:46
aherrmann-da
aherrmann-da approved these changes Jan 23, 2020
View reviewed changes
Copy link
Contributor

@aherrmann-da aherrmann-da left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@cocreature cocreature force-pushed the debug-lsp-tests branch 7 times, most recently from 6cafdb6 to c4db520 Compare January 24, 2020 07:56
@cocreature
Bump ghcide to fix GHC panics in LSP tests
521239a 
fixes #4152

changelog_begin
changelog_end
@mergify mergify bot merged commit 93d7b1a into master Jan 24, 2020
@mergify mergify bot deleted the debug-lsp-tests branch January 24, 2020 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aherrmann-da aherrmann-da aherrmann-da approved these changes

@shayne-fletcher shayne-fletcher shayne-fletcher approved these changes

@hurryabit hurryabit Awaiting requested review from hurryabit

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

LSP completion tests seem to be flaky
3 participants
@cocreature @shayne-fletcher @aherrmann-da