Disambiguate consuming vs preconsuming choices #4164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shayne-fletcher
force-pushed
the
preconsuming-choices
branch
5 times, most recently
from
bc9d668 to
bcf44bd
Compare
cocreature
approved these changes
Jan 22, 2020
changelog_begin - [DAML Compiler] Choices marked explicitly as `preconsuming` are now equivalent to a non-consuming choice that calles `archive self` at the beginning. changelog_end
shayne-fletcher
force-pushed
the
preconsuming-choices
branch
from
bcf44bd to
ac68a43
Compare
hurryabit
approved these changes
Jan 22, 2020
6 tasks
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
stefanobaghino-da
added a commit
that referenced
this pull request
Jan 23, 2020
mergify bot
pushed a commit
that referenced
this pull request
Jan 24, 2020
* Document consumability qualifiers and their privacy implications in the reference docs CHANGELOG_BEGIN [Documentation] Documented consumability qualifiers in the DAML reference docs, along with their privacy implications CHANGELOG_END * Fix WARNING: Title underline too short. * Fix DAML compile errors on reference docs code * Addresses #4134 (comment) * Addresses #4134 (comment) * Addresses #4134 (comment) * Addresses #4134 (comment) * Addresses #4134 (comment) * Review and fix according to improvements part of #4164 * Addresses #4134 (comment) * Grammar fix * Address #4134 (comment) * Address #4134 (comment) * Address #4134 (review)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of preconsuming/consuming split.