Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update hlint #4109

Merged
merged 1 commit into from
Jan 22, 2020
Merged

Update hlint #4109

merged 1 commit into from
Jan 22, 2020

Conversation

shayne-fletcher
Copy link
Contributor

@shayne-fletcher shayne-fletcher commented Jan 19, 2020

Update to digital-asset/hlint 2de70183ba81d71faa67a339fc72f8fe86a2f6d1.

@shayne-fletcher shayne-fletcher force-pushed the add-ghc-lib-parser-dep branch 4 times, most recently from 44bbdcc to 3ef9dcb Compare January 19, 2020 04:27
changelog_begin
changelog_end
@digitalasset-cla
Copy link
Member

digitalasset-cla commented Jan 21, 2020

CLA assistant check
All committers have signed the CLA.

@shayne-fletcher shayne-fletcher changed the title Depend on ghc-lib-parser-ex Update hlint Jan 21, 2020
@shayne-fletcher shayne-fletcher marked this pull request as ready for review January 21, 2020 21:23
@@ -416,6 +417,7 @@ exports_files(["stack.exe"], visibility = ["//visibility:public"])
"ghc-boot-th",
"ghc-lib",
"ghc-lib-parser",
"ghc-lib-parser-ex",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this new library?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bits of code that interact with ghc-lib-parser have been factored out into a new hlint dependency, ghc-lib-parser-ex.

Copy link
Contributor

@cocreature cocreature left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@shayne-fletcher shayne-fletcher merged commit 674eaff into master Jan 22, 2020
@shayne-fletcher shayne-fletcher deleted the add-ghc-lib-parser-dep branch January 22, 2020 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants