Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libs-scala/resources: Move Resource and friends to their own package. #4066

Merged
merged 4 commits into from
Jan 16, 2020
Merged

libs-scala/resources: Move Resource and friends to their own package. #4066

merged 4 commits into from
Jan 16, 2020

Conversation

SamirTalwar
Copy link
Contributor

@SamirTalwar SamirTalwar commented Jan 16, 2020 •
edited
Loading

I'd like to unify this with the other Resource class, used for testing.

Changelog

  • [Ledger API Server] Publish the resource management code as a library under com.digitalasset:resources.

Pull Request Checklist

  • Read and understand the contribution guidelines
  • Include appropriate tests
  • Set a descriptive title and thorough description
  • Add a reference to the issue this PR will solve, if appropriate
  • Include changelog additions in one or more commit message bodies between the CHANGELOG_BEGIN and CHANGELOG_END tags
  • Normal production system change, include purpose of change in description

NOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with /AzurePipelines run to
trigger the build.

@SamirTalwar
libs-scala/resources: Move Resource and friends to their own package.
87ae77e 
CHANGELOG_BEGIN
- [Ledger API Server] Publish the resource management code as a library
  under ``com.digitalasset:resources``.
CHANGELOG_END
stefanobaghino-da
stefanobaghino-da approved these changes Jan 16, 2020
View reviewed changes
Copy link
Contributor

@stefanobaghino-da stefanobaghino-da left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I like this a lot. Even better I'd say would be to spin off the Akka related stuff into its own package. 😉

libs-scala/resources/BUILD.bazel Outdated Show resolved Hide resolved
@mergify mergify bot merged commit b96e54f into master Jan 16, 2020
@mergify mergify bot deleted the libs-scala/resources branch January 16, 2020 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stefanobaghino-da stefanobaghino-da stefanobaghino-da approved these changes

@gerolf-da gerolf-da Awaiting requested review from gerolf-da

@rautenrieth-da rautenrieth-da Awaiting requested review from rautenrieth-da

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SamirTalwar @stefanobaghino-da