LF conversion of templates under new rules (WIP). #4030
Conversation
compiler/damlc/daml-lf-conversion/src/DA/Daml/LFConversion/Primitives.hs
Outdated
Show resolved
Hide resolved
| @@ -91,6 +91,7 @@ importDamlPreprocessor = fmap onModule | |||
| where | |||
| onModule y = y { | |||
| GHC.hsmodImports = | |||
| newImport True "GHC.Types" : | |||
There was a problem hiding this comment.
To add some context this is because the template desugaring from digital-asset/ghc#47 uses primitive.
compiler/damlc/daml-stdlib-src/DA/Internal/Template/Functions.daml
Outdated
Show resolved
Hide resolved
compiler/damlc/tests/daml-test-files/NewTemplateDesugaring.daml
Outdated
Show resolved
Hide resolved
compiler/damlc/daml-lf-conversion/src/DA/Daml/LFConversion/Primitives.hs
Outdated
Show resolved
Hide resolved
| ) | ||
| ) | ||
|
|
||
| pattern HasSignatoryDFunId, HasEnsureDFunId, HasAgreementDFunId, HasObserverDFunId |
There was a problem hiding this comment.
Much nicer than the silly name matching that I did before, thanks!
| | Just internals <- lookupUFM internalFunctions (envGHCModuleName env) | ||
| , getOccFS name `elementOfUniqSet` internals | ||
| = pure [] | ||
| -- NOTE(MH): Desugaring `template X` will result in a type class |
There was a problem hiding this comment.
I guess this is no longer necessary since we don’t have any default implementations?
There was a problem hiding this comment.
Right, and we don't want to filter out the $c methods either. We don't actually want templates to be special in any way with respect to GHC's & damlc's handling of typeclasses.
The generation of Template instances will break horribly with #4030 and we don’t actually want to use this anymore since we want to reuse old class instances. There are some cases where we might still need or want this in the future (see the inline comment), so for now, the code for this is still left intact and only disabled. changelog_begin changelog_end
|
/AzurePipelines run |
|
Pull request contains merge conflicts. |
ghost
The generation of Template instances will break horribly with #4030 and we don’t actually want to use this anymore since we want to reuse old class instances. There are some cases where we might still need or want this in the future (see the inline comment), so for now, the code for this is still left intact and only disabled. changelog_begin changelog_end
changelog_begin changelog_end
|
I tested the new damlc against a large existing repo and it built without problem. Only thing missing is to replace the ghc-lib reference with a new release. |
There was a problem hiding this comment.
Very nice. Thank you so much.
I've focused on the changes to the stdlib and they look good to me. I trust the combined forces of you, @cocreature and our tests that the changes to the conversion are good too.
No description provided.