add more information to collect_build_data output #3996
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hurryabit
approved these changes
Jan 9, 2020
This commit: - fixes an issue introduced by e2015e2 whereby the data was never saved to GCS, because if the variable _is_ set, then Azure will substitute the right side of the comparison as well as set the environment variable, so the two sides will still be equal. The new approach skips the first character of the env var and removes the dollar from the (intended) literal expression, ensuring Azure does not substitute. - adds output to the failure case because we have recently seen all commits on master fail that step, regardless of success of other jobs. CHANGELOG_BEGIN CHANGELOG_END
garyverhaegen-da
force-pushed
the
debug-collect-build-data
branch
from
03bc94f to
c89ddf4
Compare
|
After further digging, it looks like 1 just never worked after e2015e2. The problem is that Azure will replace the variable in both the env var and the Bash script, so the two sides are also equal when the substitution does happen. To fix, I have removed the dollar sign on the right side (so Azure does no substitution) and used Bash syntax to say, on the left side, "take the value of the variable starting at character 1 (i.e. skipping 0) and taking length-1 characters (i.e. until the end)". |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
collect_build_datastep has been failing on master. Based on its current output, it looks like:Regarding 1, I currently have no clue what may be happening. Regarding 2, Azure did change the enum strings used for job statuses a few weeks ago, so maybe that happened again. I don't think we'll be able to know until this runs on master.