Aligning DB contract table with domain.ActiveContract class #3989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
S11001001
requested changes
Jan 8, 2020
| @@ -111,13 +111,21 @@ private class ContractsFetch( | |||
| for { | |||
| ac <- domain.ActiveContract fromLedgerApi ce leftMap (de => | |||
| new IllegalArgumentException(s"contract ${ce.contractId}: ${de.shows}")) | |||
| lfKey <- ac.key.cata( | |||
There was a problem hiding this comment.
Suggested change
| lfKey <- ac.key.cata( | |
| lfKey <- ac.key traverse apiValueToLfValue leftMap (_.cause) |
| @@ -34,6 +34,7 @@ da_scala_library( | |||
| "@maven//:org_scalaz_scalaz_core_2_12", | |||
| "@maven//:org_tpolecat_doobie_core_2_12", | |||
| "@maven//:org_tpolecat_doobie_free_2_12", | |||
| "@maven//:org_tpolecat_doobie_postgres_2_12", | |||
There was a problem hiding this comment.
Suggested change
| "@maven//:org_tpolecat_doobie_postgres_2_12", |
Use the same technique used for insertContracts: take Get[Array[String]] as an implicit argument to selectContracts.
adding key,signatories, observers and agreement_text to DB contract table removing witnessParties Reading signatories and observers from contracts table Updating doc, removing witnessParties Address code review comments, thanks @S11001001 CHANGELOG_BEGIN [JSON API - Experimental] - Align ``contract`` table with ``domain.ActiveContract`` class. The database schema has changed, if using ``--query-store-jdbc-config``, you must rebuild the database by adding ``,createSchema=true``. See #3754. - ``witnessParties`` field is removed from all JSON responses. CHANGELOG_END
leo-da
force-pushed
the
leo-3754-domain-model-cleanup
branch
from
a6dc267 to
29bcb3e
Compare
remove witnessParties and workflowId fields. workflowId has be removed from JSON output a while ago.
S11001001
approved these changes
Jan 8, 2020
hurryabit
reviewed
Jan 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #3754
Pull Request Checklist
CHANGELOG_BEGINandCHANGELOG_ENDtagsNOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with
/AzurePipelines runtotrigger the build.